Reimplement legacy Sound class with new audio engine
#17457
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17457/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/17457/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/17457/merge#BCU1XR#0 |
|
Devhost visualization test reporter: |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
|
Devhost visualization test reporter: |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
docEdub
force-pushed
the
251114-reimplement-old-sound-class
branch
from
33d1d2f to
eb0bcc4
Compare
|
Devhost visualization test reporter: |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
|
Devhost visualization test reporter: |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
See playground #KBA3JY#4.
|
Devhost visualization test reporter: |
|
Devhost visualization test reporter: |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
…on Firefox If the arg `startTime` is even slightly in the future, Firefox throws an error. This change avoids that error and achieves the same desired result of canceling any scheduled values.
|
Devhost visualization test reporter: |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
|
Devhost visualization test reporter: |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
New audio engine `maxDistance` defaults to `10000`, but old `Sound` class should default to `100`. This change fixes it so it defaults to `100` correctly in all cases.
New audio engine `distanceModel` defaults to `inverse`, but old `Sound` class should default to `linear`. This change fixes it so it defaults to `linear` correctly in all cases.
|
Devhost visualization test reporter: |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
3 participants
No description provided.